Fix extraction failure for read-only files during archive extraction #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UnArchiver read-only file extraction issue
This PR addresses the issue where UnArchiver fails to extract files when the target file exists and is read-only.
Checklist:
extractFilemethod)Summary:
The issue occurs in
AbstractUnArchiver.extractFile()whereFiles.copywithREPLACE_EXISTINGmay fail on read-only files on some platforms. The fix deletes the existing file before copying, similar to howtarandunziphandle this scenario.Changes Made:
AbstractUnArchiver.extractFile()to delete the existing file before callingFiles.copy()setWritable(true)beforedelete()to handle Windows where read-only files cannot be deletedREPLACE_EXISTINGas a fallback for robustness (belt and suspenders approach)shouldExtractReadOnlyFile()to verify the fix works correctlyImplementation Details:
The solution uses a robust approach:
This provides maximum compatibility across different platforms (Linux, macOS, Windows) and permission scenarios.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.